Since they are the one doing the prompting, they quickly got lazy of actually reviewing the output from the LLM which means that nobody is reviewing anything.
It hasn't happened yet but I guess that is how you end up with major outages.
I find the engineers currently thriving are the ones who never gave a fuck about anything but their own advancement and are happy to drop weeks of work on others and take the credit.
Yes. if you have this attitude, great things will come to you. if you care or try to make sense of things, you'll be in misery
Everyone's doing code reviews--well, not even code reviews; just PR reviews--so how are they supposed to gain an understanding of the system.
I review a PR, I see that one new endpoint was added to the API. It looks correct. I say "LGTM" in a GitHub comment.
The sprint's almost over, everyone's in a rush to do code reviews.
I look at another PR. Somebody added a button to the UI. The button looks correct. They get a thumbs-up emoji from me. I bet they feel satisfied.
I look at another PR. Somebody changed a timeout in the settings because some people complained about dropped connections. It's a really small change, so, approved.
At what point am I supposed to understand the system? I looked at a single API endpoint, in isolation, and then a button, and then a harmless looking settings change.
I was pressured to hurry.
Am I supposed to somehow get an understanding of the big picture through this?
Imagine if instead there was time to review large logical sections of the code together. Imagine if we focused our reviews on the overall code instead of on the lines in one random PR at a time.
You need to understand the architecture of the system. The broad flows of data and domains. And then you need to understand the features of the system, aka the rules and contracts. First learn it for your team’s domain, then for adjacent domains.
Learning the minutiae of the code specifically is no longer (was it ever?) your primary job. You are an engineer of a system. You need to have a mental model of the system, start high and build up low over time.
You can use AI to build your understanding by Q&A and by drafting diagrams etc.
You're the prototype of the guy sitting at a station in a production line doing the same focused task over and over again. The guy who is putting in the windsheild of your car has no clue about engine design or electronic or ...
I used to dream we could get to scale development by componentization and industrialize software development like mechanical engineering and do the Henry Ford thing for software. It is happening in a way but very ironic inversion, it is the human element that is the component.
I get a ping "if you have a few minutes, can you review PR #XYZ - we gotta deploy today or tomorrow"
I open the PR, I realize it's a pricing engine update accompanied by 20,000 lines of additions, 4000 lines of removals, and a whole slew of logic updates to our payment calculations. I seriously question my existence and figure out how to deal with this, since it's my new job.
(New Job Description: Be AI surprised all the time, AI horrified, and AI overworked while simultaneously getting less AI done than ever. AI.)
I do. There is a lot of code out there that needs to work correctly or it will have serious consequences. Payments, inventory tracking, medical stuff, payroll. Many, many areas where it just needs to work.
You are doing it right. But the people who are giving you the money; They are doing it WRONG.
Well, you’re not until you realise that your AI has done something stupid and then you’re part of an exploit. Or exfiltrates used data to an unsecured cloud, or something equally smart.
Truth be told, it was the firm hand of the git blame-and-shame that kept our code civil and orderly. Binding contract written in blood was “the name on the blame owns the change”. If you pushed it, you owned it. For life.
Of course, mental health wasn’t so great back in those days, but I would take that over having my PR blocked all day because Chad, who’s only gift is somehow finding a new hill to die on every day, thinks zero is a “magic number” there’s no way he’s going to budge on this issue.