Hacker News new | past | comments | ask | show | jobs | submit
> how little anyone understands the code

Everyone's doing code reviews--well, not even code reviews; just PR reviews--so how are they supposed to gain an understanding of the system.

I review a PR, I see that one new endpoint was added to the API. It looks correct. I say "LGTM" in a GitHub comment.

The sprint's almost over, everyone's in a rush to do code reviews.

I look at another PR. Somebody added a button to the UI. The button looks correct. They get a thumbs-up emoji from me. I bet they feel satisfied.

I look at another PR. Somebody changed a timeout in the settings because some people complained about dropped connections. It's a really small change, so, approved.

At what point am I supposed to understand the system? I looked at a single API endpoint, in isolation, and then a button, and then a harmless looking settings change.

I was pressured to hurry.

Am I supposed to somehow get an understanding of the big picture through this?

Imagine if instead there was time to review large logical sections of the code together. Imagine if we focused our reviews on the overall code instead of on the lines in one random PR at a time.

Reviewing tiny code changes like that was never going to give you understanding of the system. That is not an AI problem.

You need to understand the architecture of the system. The broad flows of data and domains. And then you need to understand the features of the system, aka the rules and contracts. First learn it for your team’s domain, then for adjacent domains.

Learning the minutiae of the code specifically is no longer (was it ever?) your primary job. You are an engineer of a system. You need to have a mental model of the system, start high and build up low over time.

You can use AI to build your understanding by Q&A and by drafting diagrams etc.

> Am I supposed to somehow get an understanding of the big picture through this?

You're the prototype of the guy sitting at a station in a production line doing the same focused task over and over again. The guy who is putting in the windsheild of your car has no clue about engine design or electronic or ...

I used to dream we could get to scale development by componentization and industrialize software development like mechanical engineering and do the Henry Ford thing for software. It is happening in a way but very ironic inversion, it is the human element that is the component.

Yes. I am that guy. I've had big ideas about how to improve the overall project, but nobody cares, that's not my job, so I stick to thumbs-up emojis and make sure my finances are in order.

I work on coding projects in my spare time, but that's legally dubious because of the standard copyright assignment clause of employment contracts. But, look at Uber and OpenAI, sometimes legally dubious is the path to success...

loading story #50549725
I talked to some tech directors about this at work this week. Line by line code reviews aren't really possible anymore. We need the evolve the way we do code reviews but it isn't happening.
I think the solution is to develop the infrastructure needed to confidently push code without review and trust that it works because your system is so thoroughly tested. But taking the time to do this is antithetical to the goal of speeding everything up right now.
With the rate at which new features are demanded and the number of ways a single feature can fail (or be expected to behave) do you think your approach is feasible? To what degree would AI be involved in the building of this infrastructure? Past a certain level of AI involvement, would we not be back to square one?
I'm certain we work at different companies!

I get a ping "if you have a few minutes, can you review PR #XYZ - we gotta deploy today or tomorrow"

I open the PR, I realize it's a pricing engine update accompanied by 20,000 lines of additions, 4000 lines of removals, and a whole slew of logic updates to our payment calculations. I seriously question my existence and figure out how to deal with this, since it's my new job.

(New Job Description: Be AI surprised all the time, AI horrified, and AI overworked while simultaneously getting less AI done than ever. AI.)