Hacker News new | past | comments | ask | show | jobs | submit
code review is currently obsolete, but it was an important tool:

1. It was good for collaboration. Sharing how you are changing the codebase pushes everyone to row in the same direction, and provides a sense of team ownership.

2. It was good as a push for engineers to take pride in their work. Knowing someone is watching gives you subconsciously an extra reason to not cut corners. And when you spend effort not cutting corners you expect that in your teammates, which is a (potentially) virtuous circle.

3. It was good for catching mistakes. When code was expensive this was important.

Everyone thinks of code review as primarily relevant for 3, and since code is no longer expensive they think it is unimportant. But 3 isn't dead, its importance has just shifted from code to architecture. It is still an expensive mistake to screw up architecture and have other engineers build upon that flaw. Re-architecting with live users, data and/or hardware is not as simple as fixing a code bug, and it deserves attention to catch mistakes. Collaboration & pride are also still important.

This is the reason that instead of stopping review, we need to change what and how we review.

(disclosure I work in this space and run https://www.archme.io which is working to solve the above, also responded to a lower down comment with this but decided to move it to top level)

The cost of the code isn't why you reviewed it. The cost of the _failure_ is why you review it.

Code has always been cheap. The cost incurred by the organisation when the wrong code is run is getting pretty expensive (just ask MS).

It also helps with the bus factor and insider risk.

loading story #50545590
loading story #50544034