Hacker News new | past | comments | ask | show | jobs | submit
> I have no idea how the Linux maintainers do that job over a long time.

They're basically the lords of their subsystems. If something does not fit the project's vision and their own standard, it's unlikely to get merged. Imagine if you had the authority to dismiss PRs the same way and send the author back to the drawing board? But that's unlikely to happen as you'll be seen as a "bottleneck" by your managers.

I find this much easier now though. Five years ago if a Colleague sent me a large PR they had worked N days on, I'd be very reluctant to say "Ok this should be done the opposite way, but I guess it's too late for that now".

The acceptance for wasting work, or hurting someone's ego was always much lower than the acceptance for bad code that does the job right.

Now I can just say "Let's try doing this in two other ways, and pick the best, because this has such and such drawbacks". And it's so nice that this isn't a) causing a massive amount of extra work b) hurting someone's ego. So it's accepted.

So that's why I'm cautiously optimistic that LLMs and very superficial reviews can still be beneficial to quality. We just didn't reject/rewrite PRs before, now we do.

If you feel the need to send the author all the way back to the drawing board at the code review stage for any non-trivially large diff, I'd venture that the problem lies in the architecture design / project planning stage. Given you're already aligned on infrastructure, table design, and interfaces, (and company conventions like language, style, etc) how significantly can you diverge in implementation details? Can it really vary so greatly that you need to go all the way back to the drawing board?
loading story #50542796
loading story #50542358